| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION |
| Date: | 2026-06-02 00:41:04 |
| Message-ID: | CACJufxFG+vn8vdHAedGuqwb9iC58HHPGSEaLwm6_Tcv-3AyH=w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 29, 2026 at 6:58 AM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> Looks good, I have one nitpick question:
>
> + if (isnull)
> + elog(WARNING, "null conbin for relation \"%s\"",
> + RelationGetRelationName(rel));
>
> Shouldn't this be an error instead? Most existing checks treat it as
> an error, and that seems better to me as this shouldn't happen
> normally?
>
OK.
I changed it to:
> + if (isnull)
> + elog(ERROR, "null conbin for relation \"%s\"",
> + RelationGetRelationName(rel));
I also slightly rephrased the commit message.
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-recreate-wholerow-dependent-while-ALTER-COLUMN-SET-EXPRESSION.patch | text/x-patch | 13.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Chernyy | 2026-06-02 00:43:14 | Re: [PATCH] Fix libxml leaks in contrib/xml2 XPath functions |
| Previous Message | Bruce Momjian | 2026-06-02 00:35:57 | Re: [RFC PATCH v2 RESEND 0/10] Umbra: a remap-aware smgr prototype |