| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: POC: make mxidoff 64 bits |
| Date: | 2025-05-27 15:18:26 |
| Message-ID: | CACG=ezaLdhpFY9_qr7B6s7kkg_=s5S_ZD2=dsSeBNgdWWWuKbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 29 Apr 2025 at 15:01, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
wrote:
>
> I notice that transam/README does not mention multixact except one place
> in section "Transaction Emulation during Recovery". I expected it to
> document how pg_multixact/members and pg_multixact/offset are used and what
> is their layout. It's not the responsibility of this patchset to document
> it, but it will be good if we add a section about multixacts in
> transam/README. It will make reviews easier.
>
Yeah, I agree, this is a big overlook, I think. Anyone who tries to
understand how pg_multixact works has to deal with the code.
Certainly, we need to address this issue.
But for now, here is a new rebase @ 70a13c528b6e382a381f.
The only change is that following commits 15a79c7 and a0ed19e, we must also
switch to PRIu64 format.
--
Best regards,
Maxim Orlov.
| Attachment | Content-Type | Size |
|---|---|---|
| v15-0005-TEST-initdb-option-to-initialize-cluster-with-no.patch.txt | text/plain | 25.3 KB |
| v15-0003-Make-pg_upgrade-convert-multixact-offsets.patch | application/octet-stream | 17.7 KB |
| v15-0004-Get-rid-of-MultiXactMemberFreezeThreshold-call.patch | application/octet-stream | 8.8 KB |
| v15-0002-Use-64-bit-multixact-offsets.patch | application/octet-stream | 13.0 KB |
| v15-0001-Use-64-bit-format-output-for-multixact-offsets.patch | application/octet-stream | 7.2 KB |
| v15-0007-TEST-bump-catver.patch.txt | text/plain | 1.1 KB |
| v15-0006-TEST-add-src-bin-pg_upgrade-t-006_offset.pl.patch.txt | text/plain | 14.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-05-27 15:36:01 | Re: Make wal_receiver_timeout configurable per subscription |
| Previous Message | Ken Marshall | 2025-05-27 15:10:14 | Re: Cygwin support |