| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, davinder singh <davindersingh2692(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG compilation error with Visual Studio 2015/2017/2019 |
| Date: | 2020-05-04 13:29:15 |
| Message-ID: | CAC+AXB3j1GmpDSu2+Ndk-XhFbFN7bN9bd2=X=t=d9sjO+3gxQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 30, 2020 at 5:07 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > I was not aware of how many switches IsoLocaleName() already had before
> trying to backpatch. I think offering an alternative might be a cleaner
> approach, I will work on that.
> >
>
> Okay, thanks. The key point to keep in mind is to avoid touching the
> code related to prior MSVC versions as we might not have set up to
> test those.
>
Please find attached a new version following this approach.
Regards,
Juan José Santamaría Flecha
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-PG9_5-compilation-error-with-VS-2015-2017-2019_v15.patch | application/octet-stream | 7.2 KB |
| 0001-PG_10-compilation-error-with-VS-2015-2017-2019_v15.patch | application/octet-stream | 7.1 KB |
| 0001-PG-compilation-error-with-VS-2015-2017-2019_v15.patch | application/octet-stream | 7.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Juan José Santamaría Flecha | 2020-05-04 13:42:20 | Re: Postgres Windows build system doesn't work with python installed in Program Files |
| Previous Message | Rushabh Lathia | 2020-05-04 13:22:37 | Re: WIP/PoC for parallel backup |