Re: Postgres Windows build system doesn't work with python installed in Program Files

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Postgres Windows build system doesn't work with python installed in Program Files
Date: 2020-05-04 13:42:20
Message-ID: CAC+AXB0OZrffMBD8MitfvSfN-PakdXFdGgbD1BJvtazeNGsk-Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 4, 2020 at 2:18 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Mon, May 04, 2020 at 09:45:54AM +0200, Juan José Santamaría Flecha
> wrote:
> > I think these are two different issues, python PATH and build.pl
> warnings.
> > For the later, you can check woodloose logs and see the warning after
> > commit 8f00d84afc.
>
> Oh, indeed. I somewhat managed to miss these in the logs of the
> buildfarm. What if we refactored the code of build.pl so as we'd
> check first if $ARGV[0] is defined or not? If not defined, then we
> need to have a release-quality build for all the components. How does
> that sound? Something not documented is that using "release" as first
> argument enforces also a release-quality build for all the components,
> so we had better not break that part.
>

+1, seems like the way to go to me.

Regards,

Juan José Santamaría Flecha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2020-05-04 14:32:55 Re: WAL usage calculation patch
Previous Message Juan José Santamaría Flecha 2020-05-04 13:29:15 Re: PG compilation error with Visual Studio 2015/2017/2019