| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Meson doesn't define HAVE_LOCALE_T for mscv |
| Date: | 2022-11-16 00:10:52 |
| Message-ID: | CAC+AXB31DAy5pUNG4p3LXRbWo6L=QaxBUoACSH1N_NW6qz0upQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 15, 2022 at 9:02 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2022-11-15 15:35:31 +0100, Juan José Santamaría Flecha wrote:
> > On Tue, Nov 15, 2022 at 1:49 AM Andres Freund <andres(at)anarazel(dot)de>
> wrote:
> > > Hm. Is it right that the changes are only done for msvc? win32_port.h
> > > defines the types for mingw as well afaict.
>
> > Yes, it does, but configure does nothing with them, so adding those
> > defines is a new feature for MinGW but a correction for MSVC.
>
> Any chance you checked if autoconf already detects locale_t with mingw?
> Possible that mingw supplies one of the relevant headers...
>
> Otherwise it looks like a sensible improvement to me.
>
> I've checked the autoconf version of pg_config.h and it's not detected.
Also, manually inspecting <locale.h> I see no definition of locale_t in
MinGW.
Regards,
Juan José Santamaría Flecha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-11-16 00:15:15 | Re: Slow standby snapshot |
| Previous Message | Tom Lane | 2022-11-16 00:09:08 | Re: SUBTRANS: Minimizing calls to SubTransSetParent() |