Re: Meson doesn't define HAVE_LOCALE_T for mscv

From: Andres Freund <andres(at)anarazel(dot)de>
To: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Meson doesn't define HAVE_LOCALE_T for mscv
Date: 2022-11-15 20:02:53
Message-ID: 20221115200253.dtsj6b72gtpdpfeu@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Hm, the quoting was odd, making me think you had written a separate email
about the define issue. Hence the separate email...

On 2022-11-15 15:35:31 +0100, Juan José Santamaría Flecha wrote:
> On Tue, Nov 15, 2022 at 1:49 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Hm. Is it right that the changes are only done for msvc? win32_port.h
> > defines the types for mingw as well afaict.

> Yes, it does, but configure does nothing with them, so adding those
> defines is a new feature for MinGW but a correction for MSVC.

Any chance you checked if autoconf already detects locale_t with mingw?
Possible that mingw supplies one of the relevant headers...

Otherwise it looks like a sensible improvement to me.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-11-15 20:04:59 Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)
Previous Message Andres Freund 2022-11-15 19:53:18 Re: Meson doesn't define HAVE_LOCALE_T for mscv