Re: Windows port minor fixes

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Windows port minor fixes
Date: 2019-12-16 18:57:10
Message-ID: CAC+AXB2u8YYghvwRN2gNOx+gO2_6uNc+2D2KOJbYBLZqLJsuOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 16, 2019 at 6:34 PM Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
wrote:

>
> Considering that postgres only supports windows versions that have the new
> API, it would be good to make the replace.
>
>
That is not actually the case. If you check the _WIN32_WINNT logic
in src/include/port/win32.h you can see that depending on your building
tools you can get a version lower than that, for example if using MinGW.

>
> * memory leak fix to src/common/exec.c
> * CryptGenRandom change by BCryptGenRandom to src/port/pg_strong_random.c
> * link bcrypt.lib to src/tools/msvc/Mkvcbuild.pm
>
>
If you want to address 2 unrelated issues, it makes little sense to use a
single thread and 3 patches.

Regards,

Juan José Santamaría Flecha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2019-12-16 19:11:48 Re: polymorphic table functions light
Previous Message Peter Eisentraut 2019-12-16 18:53:41 polymorphic table functions light