| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | Ranier Vilela <ranier_gyn(at)hotmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Windows port minor fixes |
| Date: | 2019-12-17 04:45:17 |
| Message-ID: | 20191217044517.GH2344@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 16, 2019 at 07:57:10PM +0100, Juan José Santamaría Flecha wrote:
> If you want to address 2 unrelated issues, it makes little sense to use a
> single thread and 3 patches.
And if you actually group things together so as any individual looking
at your patches does not have to figure out which piece applies to
what, that's also better. Anyway, the patch for putenv() is wrong in
the way the memory is freed, but this has been mentioned on another
thread. We rely on MAXPGPATH heavily so your patch trying to change
the buffer length does not bring much, and the windows-crypt call is
also wrong based for the version handling, as discussed on another
thread.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-12-17 04:53:47 | Re: Request to be allotted a project or a feature in pipeline |
| Previous Message | Amit Kapila | 2019-12-17 04:43:26 | Re: Wrong assert in TransactionGroupUpdateXidStatus |