| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Clean up some old cruft related to Windows |
| Date: | 2020-02-18 11:05:42 |
| Message-ID: | CAC+AXB1=uMRRQcbEtwOvaXpPp3DYPaqR3H6aR9B0muRAa6gmSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 18, 2020 at 7:54 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Thu, Dec 19, 2019 at 08:09:45PM +0100, Juan José Santamaría Flecha
> wrote:
> > This is probably not an issue for the supported MSVC and their SDK, but
> > current MinGW defaults to Windows 2003 [1]. So I would suggest a logic
> like:
> >
> > #define WINNTVER(ver) ((ver) >> 16)
> > #define NTDDI_VERSION 0x06000100
> > #define _WIN32_WINNT WINNTVER(NTDDI_VERSION)
> >
> > [1]
> >
> https://github.com/mirror/mingw-w64/blob/master/mingw-w64-headers/include/sdkddkver.h
>
> You're right, thanks for the pointer. This is this part of the
> header:
> #define NTDDI_VERSION NTDDI_WS03
>
> Thinking more about that, the changes in win32.h are giving me cold
> feet.
>
>
Maybe this needs a specific thread, as it is not quite cruft but something
that will require maintenance.
Regards,
Juan José Santamaría Flecha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Juan José Santamaría Flecha | 2020-02-18 11:26:06 | Re: Clean up some old cruft related to Windows |
| Previous Message | Kyotaro Horiguchi | 2020-02-18 10:59:22 | Re: Parallel copy |