| From: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
|---|---|
| To: | Tristan Partin <tristan(at)neon(dot)tech> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: test_extensions: fix inconsistency between meson.build and Makefile |
| Date: | 2023-06-17 14:40:18 |
| Message-ID: | CABwTF4Wz41pNMJ9q3tpH=6mnvg6aopDU5Lzvers5=6=WJVekww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 16, 2023 at 1:56 PM Tristan Partin <tristan(at)neon(dot)tech> wrote:
>
> On Fri Jun 16, 2023 at 3:29 PM CDT, Jeff Davis wrote:
> > Patch attached. Currently, the Makefile specifies NO_LOCALE=1, and the
> > meson.build does not.
>
> Looks alright to me, but it might be nicer to change the order of
> arguments to match contrib/unaccent/meson.build:40. Might help with
> grepping in the future.
It seems that Jeff's patch tried to match the precedent set in
src/test/modules/test_oat_hooks/meson.build.
No matter which ordering Jeff's patch uses, it will be inconsistent
with one of the existing order of the options.
So attached is updated patch that makes the order consistent across
all 3 occurrences.
Best regards,
Gurjeet
http://Gurje.et
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-test_extensions-make-meson.build-consistent-with-.patch | application/octet-stream | 769 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Evan Jones | 2023-06-17 14:57:05 | Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific |
| Previous Message | Andrew Dunstan | 2023-06-17 14:08:32 | Re: run pgindent on a regular basis / scripted manner |