Re: run pgindent on a regular basis / scripted manner

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Jelte Fennema <postgres(at)jeltef(dot)nl>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: 2023-06-17 14:08:32
Message-ID: 1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-06-15 Th 12:12, Andrew Dunstan wrote:
>
>
> On 2023-06-15 Th 11:26, Jelte Fennema wrote:
>> On Sat, 22 Apr 2023 at 13:42, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>>> Perhaps we should start with a buildfarm module, which would run pg_indent --show-diff. That would only need to run on one animal, so a failure wouldn't send the whole buildfarm red. This would be pretty easy to do.
>> Just to be clear on where we are. Is there anything blocking us from
>> doing this, except for the PG16 branch cut? (that I guess is planned
>> somewhere in July?)
>>
>> Just doing this for pgindent and not for perltidy would already be a
>> huge improvement over the current situation IMHO.
>
>
> The short answer is that some high priority demands from $dayjob got
> in the way. However, I hope to have it done soon.
>

See
<https://github.com/PGBuildFarm/client-code/commit/f9c1c15048b412d34ccda8020d989b3a7b566c05>

I have set up a new buildfarm animal called koel which will run the module.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gurjeet Singh 2023-06-17 14:40:18 Re: test_extensions: fix inconsistency between meson.build and Makefile
Previous Message Tomas Vondra 2023-06-17 13:45:07 Re: Incorrect estimation of HashJoin rows resulted from inaccurate small table statistics