From: | Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Getting rid of pre-assignment of index names in CREATE TABLE LIKE |
Date: | 2012-07-15 15:38:36 |
Message-ID: | CABwTF4UH0w1wXzYdPkENBjX1pxnToEPEK_H6J9bWaHCF5hEMJw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Jul 14, 2012 at 4:02 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> While I was at it, it seemed like DefineIndex's parameter list had grown
> well past any sane bound, so I refactored it to pass the IndexStmt
> struct as-is rather than passing all the fields individually.
>
> With or without that choice, though, this approach means a change in
> DefineIndex's API, as well as the contents of struct IndexStmt. That
> means it's probably unsafe to back-patch, since it seems plausible that
> there might be third-party code out there that creates indexes and would
> use these interfaces.
>
> I would like to sneak this fix into 9.2, though. Does anyone think
> it's already too late to be touching these APIs for 9.2?
>
I'd like us to stick to the standard practice of not changing features/API
in beta releases.
Best regards,
--
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-07-15 15:49:54 | Re: Getting rid of pre-assignment of index names in CREATE TABLE LIKE |
Previous Message | Cédric Villemain | 2012-07-15 10:52:32 | Re: Use of rsync for data directory copying |