Re: Implement missing join selectivity estimation for range types

From: Haibo Yan <tristan(dot)yim(at)gmail(dot)com>
To: SCHOEMANS Maxime <maxime(dot)schoemans(at)ulb(dot)be>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Damir Belyalov <dam(dot)bel07(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, SAKR Mahmoud <mahmoud(dot)sakr(at)ulb(dot)be>, Diogo Repas <diogo(dot)repas(at)gmail(dot)com>, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
Subject: Re: Implement missing join selectivity estimation for range types
Date: 2026-04-23 02:25:55
Message-ID: CABXr29Edby6Cbbaps_OQh-+kvKx+XFNe26jc=sBxWhjaYO9raQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 21, 2026 at 6:54 AM SCHOEMANS Maxime <maxime(dot)schoemans(at)ulb(dot)be>
wrote:

> Hi Haibo,
>
> Thanks for the continued feedback. Attached is v8 addressing your nits
> on patch 2:
>
> - Reworded the commit message to say "the same outer-bounds-based
> estimator can be reused" instead of implying the code is just
> duplicated.
> - Made comments in multirangejoinsel type-neutral where they
> unnecessarily said "range" (e.g. "bound histograms" instead of
> "range histograms", "empty values" instead of "empty ranges").
> - Added the reverse mixed-direction tests (multirange x range).
>
> Regards,
> Maxime
>

Hi Maxime,

Thanks for addressing those points — this looks good to me now.

If you don’t mind, I’ve created a CommitFest entry for this:
https://commitfest.postgresql.org/patch/6668/

I’ve listed both of us as authors.

I’m not a committer yet, so we’ll need someone else to review and
(hopefully) pick this up for commit.

Thanks again for the work on this.

Best regards,
Haibo

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-04-23 02:31:31 Re: Parallel Apply
Previous Message Chao Li 2026-04-23 02:02:31 Re: pg_test_timing: fix unit typo and widen diff type