| From: | SCHOEMANS Maxime <maxime(dot)schoemans(at)ulb(dot)be> |
|---|---|
| To: | Haibo Yan <tristan(dot)yim(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Damir Belyalov <dam(dot)bel07(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, SAKR Mahmoud <mahmoud(dot)sakr(at)ulb(dot)be>, Diogo Repas <diogo(dot)repas(at)gmail(dot)com>, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
| Subject: | Re: Implement missing join selectivity estimation for range types |
| Date: | 2026-04-21 13:54:33 |
| Message-ID: | DB8P190MB073174810A391519D4B0BD5BF02C2@DB8P190MB0731.EURP190.PROD.OUTLOOK.COM |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Haibo,
Thanks for the continued feedback. Attached is v8 addressing your nits
on patch 2:
- Reworded the commit message to say "the same outer-bounds-based
estimator can be reused" instead of implying the code is just
duplicated.
- Made comments in multirangejoinsel type-neutral where they
unnecessarily said "range" (e.g. "bound histograms" instead of
"range histograms", "empty values" instead of "empty ranges").
- Added the reverse mixed-direction tests (multirange x range).
Regards,
Maxime
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Improve-range-join-selectivity-estimation-for.patch | application/octet-stream | 20.7 KB |
| v8-0002-Improve-multirange-join-selectivity-estimation-fo.patch | application/octet-stream | 28.2 KB |
| v8-0003-Remove-duplicate-selectivity-functions-between-ra.patch | application/octet-stream | 34.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-04-21 13:54:54 | Non-robust plpgsql_trap test |
| Previous Message | Álvaro Herrera | 2026-04-21 13:51:10 | Re: Cleanup shadows variable warnings, round 1 |