| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: hba.c:3160:18: warning: comparison of unsigned enum expression |
| Date: | 2021-04-07 12:20:25 |
| Message-ID: | CABUevEzyHd7_69oAKS3N5fUxnd2D0Ov2Pi5UY5bOt_LxskiCqA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 7, 2021 at 2:17 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Apr 07, 2021 at 02:01:42PM +0200, Magnus Hagander wrote:
> > That's very close to mine (see one email later). Let's bikeshed about
> > the details. I think it's basically the same for current usecases, but
> > that taking the UserAuth as the parameter is cleaner and potentially
> > more useful for the future.
>
> Missed it, sorry about that. Using UserAuth as argument is fine by
> me. If you wish to apply that, please feel free. I am fine to do
> that myself, but that will have to wait until tomorrow my time.
Ok, I'll go ahead and push it. Thanks for confirming the fix!
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-04-07 12:24:14 | Re: hba.c:3160:18: warning: comparison of unsigned enum expression |
| Previous Message | Erik Rijkers | 2021-04-07 12:18:13 | Re: hba.c:3160:18: warning: comparison of unsigned enum expression |