Re: release schedule?

On Wed, May 2, 2018 at 6:23 PM, Jonathan S. Katz <jkatz(at)postgresql(dot)org>
wrote:

>
> On May 2, 2018, at 12:14 PM, Jonathan S. Katz <jkatz(at)postgresql(dot)org>
> wrote:
>
>
> On May 2, 2018, at 11:00 AM, Jonathan S. Katz <jkatz(at)postgresql(dot)org>
> wrote:
>
>
> On May 2, 2018, at 10:57 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>
> On Wed, May 2, 2018 at 4:40 PM, Jonathan S. Katz <jkatz(at)postgresql(dot)org>
> wrote:
>
> The search tool on postgresql.org is for searching things like the
> documentation and mailing list archive. If you’re looking for particular
> pages, your favorite search engine of choice will get you what you are
> looking for.
>
>
> The site search is certainly *supposed* to work for that. Clearly it's
> somewhat broken.
>
>
> I don't have a strong opinion about whether it's broken or not, but
> if the search doesn't cover the entire universe of "*.postgresql.org"
> content, I think it'd be a good idea to have some text on the search
> page explaining what it does cover.
>
>
> Fair. TBH I forgot that it was supposed to cover the regular pages
> because I tend to use $FAVORITE_SEARCH_ENGINE to find
> what I’m looking for.
>
> I’ll add this as a ticket to Redmine to ensure we investigate.
>
>
> Per off-list discussion with Magnus, we discovered the issue. The proposed
> patch is attached.
>
> If no objections I will commit shortly and refresh the sitemap.
>
>
> Tested against the generated sitemap.xml locally and made one change
> to the patch. Will commit this version shortly if no objection
>
>
Nitpicking that you should be using os.path.join() etc. Meaning:

pages_dir = os.path.abspath(os.path.join(os.path.dirname(__file__),
'../../templates/pages/'))

(from memory, verify that it actually works :P)

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>