| From: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ray Stell <stellr(at)vt(dot)edu>, PostgreSQL WWW <PGSQL-WWW(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: release schedule? |
| Date: | 2018-05-02 17:27:55 |
| Message-ID: | 3BD1811D-4DF9-43A1-88F8-423A8B80C6FA@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
> On May 2, 2018, at 12:35 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> On Wed, May 2, 2018 at 6:23 PM, Jonathan S. Katz <jkatz(at)postgresql(dot)org <mailto:jkatz(at)postgresql(dot)org>> wrote:
>
>> On May 2, 2018, at 12:14 PM, Jonathan S. Katz <jkatz(at)postgresql(dot)org <mailto:jkatz(at)postgresql(dot)org>> wrote:
>>
>>>
>>> On May 2, 2018, at 11:00 AM, Jonathan S. Katz <jkatz(at)postgresql(dot)org <mailto:jkatz(at)postgresql(dot)org>> wrote:
>>>
>>>>
>>>> On May 2, 2018, at 10:57 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>>>>
>>>> Magnus Hagander <magnus(at)hagander(dot)net <mailto:magnus(at)hagander(dot)net>> writes:
>>>>> On Wed, May 2, 2018 at 4:40 PM, Jonathan S. Katz <jkatz(at)postgresql(dot)org <mailto:jkatz(at)postgresql(dot)org>>
>>>>> wrote:
>>>>>> The search tool on postgresql.org <http://postgresql.org/> is for searching things like the
>>>>>> documentation and mailing list archive. If you’re looking for particular
>>>>>> pages, your favorite search engine of choice will get you what you are
>>>>>> looking for.
>>>>
>>>>> The site search is certainly *supposed* to work for that. Clearly it's
>>>>> somewhat broken.
>>>>
>>>> I don't have a strong opinion about whether it's broken or not, but
>>>> if the search doesn't cover the entire universe of "*.postgresql.org <http://postgresql.org/>"
>>>> content, I think it'd be a good idea to have some text on the search
>>>> page explaining what it does cover.
>>>
>>> Fair. TBH I forgot that it was supposed to cover the regular pages
>>> because I tend to use $FAVORITE_SEARCH_ENGINE to find
>>> what I’m looking for.
>>>
>>> I’ll add this as a ticket to Redmine to ensure we investigate.
>>
>> Per off-list discussion with Magnus, we discovered the issue. The proposed
>> patch is attached.
>>
>> If no objections I will commit shortly and refresh the sitemap.
>
> Tested against the generated sitemap.xml locally and made one change
> to the patch. Will commit this version shortly if no objection
>
>
> Nitpicking that you should be using os.path.join() etc. Meaning:
>
> pages_dir = os.path.abspath(os.path.join(os.path.dirname(__file__), '../../templates/pages/'))
>
> (from memory, verify that it actually works :P)
Per more off-list discussion, please see attached patch.
Jonathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2018-05-03 01:56:01 | Re: release schedule? |
| Previous Message | Magnus Hagander | 2018-05-02 16:35:42 | Re: release schedule? |