Re: Somebody broke commit hook for git push --tags?

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: Somebody broke commit hook for git push --tags?
Date: 2019-09-26 19:01:23
Message-ID: CABUevEzjkjKBBTb+iSNSTWQNGFVQYdMBKwevkZ1cppHuiimO1g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Wed, Sep 25, 2019 at 12:20 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> When I tried to push the RC1 tag to gitmaster just now, I got
>
> $ git push --tags
> Total 0 (delta 0), reused 0 (delta 0)
> remote: Traceback (most recent call last):
> remote: File "hooks/post-receive", line 414, in <module>
> remote: raise Exception("Unknown tag type '%s'" % t)
> remote: Exception: Unknown tag type 'b'commit''
> To ssh://git(at)gitmaster(dot)postgresql(dot)org/postgresql.git
> * [new tag] REL_12_RC1 -> REL_12_RC1
> $
>
> It looks like the tag got pushed anyway, but this was a bit scary.
>
>
That was indeed me. *This* was fallout from that deployment I did a few
days ago that I was initially blaming a different problem on.

I've pushed what I believe is a fix to that.

//Magnus

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Thomas Munro 2019-09-27 01:36:15 Re: BUG #16026: default_tablespace in postgresql.conf is used instead of the database's default.
Previous Message Tom Lane 2019-09-26 15:01:17 Re: BUG #16026: default_tablespace in postgresql.conf is used instead of the database's default.