From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL <Pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME |
Date: | 2011-10-12 14:33:26 |
Message-ID: | CABUevEyjK-tXUGNQxeuQmU9OqbdUbEUZqLsgYZAfuHQTL+3mCQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Wed, Oct 12, 2011 at 16:31, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 10/12/2011 10:12 AM, Tom Lane wrote:
>>
>> Robert Haas<robertmhaas(at)gmail(dot)com> writes:
>>>
>>> We could do that, but I think Heikki's idea of adding a comment would
>>> help a lot.
>>
>> +1. Simple, easy, should help significantly.
>>
>> Also, I disagree with the position that the files "aren't SQL files".
>> Sure they are. You'd want them treated as SQL by your editor, for
>> example. So changing the extension is just wrong.
>>
>
> *shrug* ok. Another thought I had was to have the file raise an error and
> have that filtered out by the extension mechanism. But I'm not sure if it's
> worth the trouble.
How about adding something like
-- \\psql_hates_this
-- rest of comment
and then at least have new versions of psql find that and stop
processing the file with a more useful error at that point? Or maybe
that's overengineering..
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-10-12 14:50:17 | Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME |
Previous Message | Andrew Dunstan | 2011-10-12 14:31:26 | Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-10-12 14:37:11 | Re: COUNT(*) and index-only scans |
Previous Message | Andrew Dunstan | 2011-10-12 14:31:26 | Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME |