Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL <Pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME
Date: 2011-10-12 14:31:26
Message-ID: 4E95A4BE.8050501@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 10/12/2011 10:12 AM, Tom Lane wrote:
> Robert Haas<robertmhaas(at)gmail(dot)com> writes:
>> We could do that, but I think Heikki's idea of adding a comment would
>> help a lot.
> +1. Simple, easy, should help significantly.
>
> Also, I disagree with the position that the files "aren't SQL files".
> Sure they are. You'd want them treated as SQL by your editor, for
> example. So changing the extension is just wrong.
>

*shrug* ok. Another thought I had was to have the file raise an error
and have that filtered out by the extension mechanism. But I'm not sure
if it's worth the trouble.

cheers

andrew

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Magnus Hagander 2011-10-12 14:33:26 Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME
Previous Message Tom Lane 2011-10-12 14:12:39 Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-10-12 14:33:26 Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME
Previous Message Tom Lane 2011-10-12 14:29:39 Re: COUNT(*) and index-only scans