Re: Small doc patch about pg_service.conf

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Fetter <david(at)fetter(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small doc patch about pg_service.conf
Date: 2015-01-03 21:41:09
Message-ID: CABUevEyUOWDRiSuCUNpqH8aJqU4h+mv5kE9buXTzBVQsDiuJ_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 3, 2015 at 9:03 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> David Fetter <david(at)fetter(dot)org> writes:
> > On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote:
> >> The old and the new documentation are both wrong. The directory libpq
> >> consults is `pg_config --sysconfdir`, which is packager-selected but
> rarely
> >> matches /etc itself. parseServiceInfo() has the code in question.
>
> > On my Fedora system, $(pg_config --sysconfdir) is /etc. What should
> > we put in the documentation?
>
> On an install-from-source, it's $installroot/etc. So the new
> documentation is very definitely more wrong than the old, which
> at least was vague about which etc directory it meant.
>

Well, it's more correct for the vast majority of installations. And more
wrong for others. I'd still say that it's a net improvement.

We could do worse than to say it's in the directory printed by
> "pg_config --sysconfdir".
>

Yeah. But let's make sure we include "usually /etc" or something like that.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2015-01-03 21:45:37 Re: Updating copyright notices to 2015 for PGDG
Previous Message David Fetter 2015-01-03 21:33:23 Re: Small doc patch about pg_service.conf