Re: Small doc patch about pg_service.conf

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small doc patch about pg_service.conf
Date: 2015-01-03 21:33:23
Message-ID: 20150103213322.GE26414@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 03, 2015 at 03:03:45PM -0500, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > On Sat, Jan 03, 2015 at 02:36:50PM -0500, Noah Misch wrote:
> >> The old and the new documentation are both wrong. The directory libpq
> >> consults is `pg_config --sysconfdir`, which is packager-selected but rarely
> >> matches /etc itself. parseServiceInfo() has the code in question.
>
> > On my Fedora system, $(pg_config --sysconfdir) is /etc. What should
> > we put in the documentation?
>
> On an install-from-source, it's $installroot/etc. So the new
> documentation is very definitely more wrong than the old, which
> at least was vague about which etc directory it meant.
>
> We could do worse than to say it's in the directory printed by
> "pg_config --sysconfdir".

Something like the attached?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
fix_pg_service_conf_location_002.patch text/plain 758 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2015-01-03 21:41:09 Re: Small doc patch about pg_service.conf
Previous Message Andres Freund 2015-01-03 20:47:56 Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments