Re: Wincrypt.h vs wincrypt.h

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Wincrypt.h vs wincrypt.h
Date: 2017-04-14 19:29:10
Message-ID: CABUevEyCFedi3+RJxavv3MWUKBVcJWeqNMqGt33zxxfBzNSqNQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 14, 2017 at 9:27 PM, Andrew Dunstan <
andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:

>
> Commit fe0a0b59 included this line:
>
> #include <Wincrypt.h>
>
> On Windows file names are not case sensitive, so the "W" works fine, but
> as I discovered this morning, if you're cross-compiling on Linux it
> matters very much, and mingw-w64 ships headers with lower case file
> names, in this case "wincrypt.h". Therefore, unless there's an objection
> I propose to lower case that "W".
>

+1. Regardless of the cross compiling, I believe using lowercase is more or
less the convention on Windows for this.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-04-14 19:33:31 Re: SCRAM authentication, take three
Previous Message Andrew Dunstan 2017-04-14 19:27:06 Wincrypt.h vs wincrypt.h