| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it> |
| Subject: | Re: Updated backup APIs for non-exclusive backups |
| Date: | 2016-03-16 16:19:47 |
| Message-ID: | CABUevEy7Yai_dMPioH5A3cyWp-dY6mxAFsxfeYCyu=QZ24zPGA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 16, 2016 at 5:06 PM, David Steele <david(at)pgmasters(dot)net> wrote:
> Hi Magnus,
>
> On 3/2/16 12:49 PM, Marco Nenciarini wrote:
>
> > I've finally found some time to take a look to the patch.
> >
> > It applies with some fuzziness on master, but the result looks correct.
> > Unfortunately the OID of the new pg_stop_backup function conflicts with
> > "pg_blocking_pids()" patch (52f5d578d6c29bf254e93c69043b817d4047ca67).
> >
> > After changing it the patch does not compile:
>
> It's been two weeks since Marco found these issues in the patch. Please
> provide an updated patch soon or I will mark this "returned with feedback".
>
>
Hi!
Thanks for the note - I had missed Marco's response completely!
I'll take a look at it once Nordic PGDay is done!
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-03-16 16:36:49 | Re: Pushdown target list below gather node (WAS Re: WIP: Upper planner pathification) |
| Previous Message | David Steele | 2016-03-16 16:19:17 | Re: pg_ctl promote wait |