Re: BUG #14230: Wrong timeline returned by pg_stop_backup on a standby

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>, Francesco Canovai <francesco(dot)canovai(at)2ndquadrant(dot)it>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #14230: Wrong timeline returned by pg_stop_backup on a standby
Date: 2016-07-11 13:15:15
Message-ID: CABUevExzrYo8WDwUvVaaFHZwXw+dbnBGpFv5fJJ3PgJiPMmMaw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, Jul 11, 2016 at 3:05 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:

> On Mon, Jul 11, 2016 at 7:01 PM, Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
> > But isn't this also a pre-existing bug in 9.5? Or did we change something
> > else that suddenly made it visible?
>
> What has been patched here is a defect caused by pg_start_backup(),
> and not pg_basebackup. In the case of the latter, ThisTimelineID gets
> set by GetStandbyFlushRecPtr() in the context of the WAL sender used
> to send the base backup. In short, this is only a defect of 9.6, where
> pg_start_backup() can be used on standbys for the first time for
> non-exclusive backups.
>
> So the issue does not actually pre-exist, GetStandbyFlushRecPtr()
> playing its role to set up the timeline ID.

Ah, that's where we gt it from. Gotcha, makes sense. Thanks for confirming!

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message David G. Johnston 2016-07-11 13:48:24 Re: BUG #14241: i want to do commit and rollback in one plpgsql block..
Previous Message David G. Johnston 2016-07-11 13:14:01 Re: BUG #14241: i want to do commit and rollback in one plpgsql block..

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-07-11 14:10:00 Re: pg_hba_lookup function to get all matching pg_hba.conf entries
Previous Message Michael Paquier 2016-07-11 13:05:54 Re: BUG #14230: Wrong timeline returned by pg_stop_backup on a standby