| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>, Francesco Canovai <francesco(dot)canovai(at)2ndquadrant(dot)it>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG #14230: Wrong timeline returned by pg_stop_backup on a standby |
| Date: | 2016-07-11 13:05:54 |
| Message-ID: | CAB7nPqT=sLupjo6f-DKoAGN0y88-78XDZ3chQ9jV9833Wc4XwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, Jul 11, 2016 at 7:01 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> But isn't this also a pre-existing bug in 9.5? Or did we change something
> else that suddenly made it visible?
What has been patched here is a defect caused by pg_start_backup(),
and not pg_basebackup. In the case of the latter, ThisTimelineID gets
set by GetStandbyFlushRecPtr() in the context of the WAL sender used
to send the base backup. In short, this is only a defect of 9.6, where
pg_start_backup() can be used on standbys for the first time for
non-exclusive backups.
So the issue does not actually pre-exist, GetStandbyFlushRecPtr()
playing its role to set up the timeline ID.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2016-07-11 13:14:01 | Re: BUG #14241: i want to do commit and rollback in one plpgsql block.. |
| Previous Message | Amit Kapila | 2016-07-11 11:26:59 | Re: BUG #14230: Wrong timeline returned by pg_stop_backup on a standby |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-07-11 13:15:15 | Re: BUG #14230: Wrong timeline returned by pg_stop_backup on a standby |
| Previous Message | Craig Ringer | 2016-07-11 12:46:49 | Re: PSA: Systemd will kill PostgreSQL |