| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alex Kliukin <alexk(at)hintbits(dot)com>, Nick B <nbedxp(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_basebackup, walreceiver and wal_sender_timeout |
| Date: | 2019-01-29 09:45:34 |
| Message-ID: | CABUevExReCR7FjC9_ekMXpuzbGhMYu2FWpHztrJraY9JkxTbaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 29, 2019 at 6:19 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Mon, Jan 28, 2019 at 02:00:59PM +0100, Alex Kliukin wrote:
> > While reading the doc page for the pg_basebackup, I've been confused
> > by the fact that it says WAL files will be written to .tarballs
> > (either base.tar or pg_wal.tar) when pg_basebackup is instructed to
> > stream WALs alongside the backup itself. I think it makes sense to
> > elaborate that it only happens when tar format is specified (doc
> > patch is attached).
>
> Agreed. The current wording can be confusing depending on the format,
> and your suggestion looks right. Any opinions from others?
>
Agreed, definitely confusing.
Since you also agreed on it, I went ahead and pushed (with backpatch).
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-01-29 09:51:04 | Re: COPY FROM WHEN condition |
| Previous Message | Amit Langote | 2019-01-29 09:32:27 | Re: speeding up planning with partitions |