Re: pg_basebackup, walreceiver and wal_sender_timeout

From: Oleksii Kliukin <alexk(at)hintbits(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Nick B <nbedxp(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup, walreceiver and wal_sender_timeout
Date: 2019-01-29 13:02:53
Message-ID: 3D16909A-939A-4BCC-A261-FF815ED9F3FF@hintbits.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 29. Jan 2019, at 10:45, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> On Tue, Jan 29, 2019 at 6:19 AM Michael Paquier <michael(at)paquier(dot)xyz <mailto:michael(at)paquier(dot)xyz>> wrote:
> On Mon, Jan 28, 2019 at 02:00:59PM +0100, Alex Kliukin wrote:
> > While reading the doc page for the pg_basebackup, I've been confused
> > by the fact that it says WAL files will be written to .tarballs
> > (either base.tar or pg_wal.tar) when pg_basebackup is instructed to
> > stream WALs alongside the backup itself. I think it makes sense to
> > elaborate that it only happens when tar format is specified (doc
> > patch is attached).
>
> Agreed. The current wording can be confusing depending on the format,
> and your suggestion looks right. Any opinions from others?
>
> Agreed, definitely confusing.
>
> Since you also agreed on it, I went ahead and pushed (with backpatch).

Thanks a lot (and to Michael as well for looking into it)!

Cheers,
Oleksii

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2019-01-29 14:04:38 Re: pgsql: Build src/port files as a library with -fPIC, and use that in li
Previous Message Michael Paquier 2019-01-29 12:36:13 Re: pg_basebackup, walreceiver and wal_sender_timeout