Re: perlcritic

On Sep 1, 2015 6:25 AM, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com> wrote:
>
> On Tue, Sep 1, 2015 at 12:57 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > We now have 80+ Perl files in our tree, and it's growing. Some of those
> > files were originally written for Perl 4, and the coding styles and
> > quality are quite, uh, divergent. So I figured it's time to clean up
> > that code a bit. I ran perlcritic over the tree and cleaned up all the
> > warnings at level 5 (the default, least severe).
>
> Do you think we should be concerned about the increased difficulty to
> backpatch fixes if this patch is applied? I personally think that's
> fine to do this cleanup on HEAD only, still others may have a
> different opinion.

It seems like something we want to do at some point, so we're going to have
to take the pain at some point.

We might want to wait until after we get 9.5 to rc as there's likely to be
more changes then, but I don't see any point in delaying it beyond that.

/Magnus