Re: Reporting query on crash even if completed

On Mon, Sep 18, 2017 at 6:12 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Mon, Sep 18, 2017 at 9:47 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Now, for pg_stat_activity part of the argument why this wouldn't be
> > confusing was that you could also see the "state" field. Maybe we
> > should try to shoehorn equivalent info into the crash log entry?
>
> Yeah, I think so. Really, I think this is an inadvertency, and thus a
>

Yeah, I agree. That was nothing I recall thinking about at the time, so
strictly speaking it's a bug.

> bug. But instead of just not showing the query when the backend is
> idle, I'd change the display for that case to:
>
> DETAIL: Failed process was idle; last query was: %s
>
> Or something like that. I guess we'd need another case for a backend
> that crashed without ever running a query.
>

+1, this is a better solution.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>