| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: Reporting query on crash even if completed |
| Date: | 2017-09-18 17:12:40 |
| Message-ID: | 1085.1505754760@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Sep 18, 2017 at 9:47 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Now, for pg_stat_activity part of the argument why this wouldn't be
>> confusing was that you could also see the "state" field. Maybe we
>> should try to shoehorn equivalent info into the crash log entry?
> Yeah, I think so. Really, I think this is an inadvertency, and thus a
> bug. But instead of just not showing the query when the backend is
> idle, I'd change the display for that case to:
> DETAIL: Failed process was idle; last query was: %s
WFM.
> Or something like that. I guess we'd need another case for a backend
> that crashed without ever running a query.
We already print nothing in that case, which seems fine.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2017-09-18 17:14:39 | Re: Reporting query on crash even if completed |
| Previous Message | Robert Haas | 2017-09-18 17:08:33 | Re: Boom filters for hash joins (was: A design for amcheck heapam verification) |