Re: [RFC] Change the default of update_process_title to off

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [RFC] Change the default of update_process_title to off
Date: 2016-08-16 09:53:25
Message-ID: CABUevEwCybqwq-z5oWV=XMuT1FabpBJrc7g3rrffZPF9=KG2TQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 5, 2016 at 12:25 PM, Tsunakawa, Takayuki <
tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:

> > From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> > Yeah, I think I agree. It would be bad to disable it by default on Unix,
> > because ps(1) is a very standard tool there, but the same argument
> doesn't
> > hold for Windows.
>
> It seems that we could reach a consensus. The patch is attached. I'll
> add this to the next CommitFest.
>
> > Another route to a solution would be to find a cheaper way to update the
> > process title on Windows ... has anyone looked for alternatives?
>
> I couldn't find an alternative solution after asking some Windows support
> staff.
>

FWIW, I remember this from back in the days when this was written. We kind
of expected this would be slow already back then, but couldn't find a
better way at the time either. And back then, I guess there were just
enough *other* things that were slow with pg-on-windows that it didn't
become as obvious.

So - +1 for changing the defaults as suggested.

What's our take on backpatching such changes? Should this be 9.6 only, or
back further?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message FarjadFarid(ChkNet) 2016-08-16 11:00:34 Re: C++ port of Postgres
Previous Message Magnus Hagander 2016-08-16 09:22:24 Re: Anyone want to update our Windows timezone map?