From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [doc] minor wording improvement in a couple of places |
Date: | 2020-09-07 10:30:27 |
Message-ID: | CABUevEw+Jj3O4LgqBzvG-XmV59pg5ARLrufJO0Fz9LAQJXMefg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Sep 7, 2020 at 6:34 AM Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>
wrote:
> Hi
>
> On these pages:
>
> https://www.postgresql.org/docs/current/fdw-callbacks.html
> https://www.postgresql.org/docs/current/tablesample-method.html
>
> we have the phrase:
>
> "..., which see for additional details."
>
> which strikes me as a bit odd. Suggested phrasing:
>
> "...; see this file for additional details."
>
>
I agree this sounds very weird. However, this phrasing is also fairly
common in comments around the code.
I was first guessing that this came out of one of us non-english native
speakers, but AFAICT it's a mix of authors and definitely including those
natively speaking the language.
I would still suggest that we change it, because it does sound odd to me as
well, but I'll defer a bit and see if others might think we should keep it.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
From | Date | Subject | |
---|---|---|---|
Next Message | Andrey V. Lepikhov | 2020-09-07 10:31:09 | Re: [POC] Fast COPY FROM command for the table with foreign partitions |
Previous Message | Asif Rehman | 2020-09-07 10:02:49 | Re: Allow CURRENT_ROLE in GRANTED BY |