Re: MERGE SQL statement for PG12

From: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
To: Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: MERGE SQL statement for PG12
Date: 2018-10-29 09:23:54
Message-ID: CABOikdPraSx-f8b+Ojp4P_HUVi8pcNVWQu2+VDoX9pnunb5j6w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 30, 2018 at 2:55 AM Jaime Casanova <
jaime(dot)casanova(at)2ndquadrant(dot)com> wrote:

> On Mon, 24 Sep 2018 at 05:15, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
> wrote:
> >
> > A new version rebased against the current master is attached.
> >
>
> Hi Pavan,
>
> A day after you posted this patch commit
> 29c94e03c7d05d2b29afa1de32795ce178531246 removed ExecStoreTuple.
> I'm right in believe that the change in
> src/backend/executor/execMerge.c should be for ExecStoreHeapTuples?
>
> - ExecStoreTuple(&tuple, mtstate->mt_existing, buffer, false);
> + ExecStoreHeapTuple(&tuple, mtstate->mt_existing, false);
>
>
Hi Jaime,

Thanks for keeping an eye on the patch. I've rebased the patch against the
current master. A new version is attached.

Thanks,
Pavan

--
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-MERGE-SQL-Command-following-SQL-2016_v5.patch application/octet-stream 391.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2018-10-29 10:05:08 Re: PostgreSQL vs SQL/XML Standards
Previous Message Amit Langote 2018-10-29 09:23:00 Re: CVE-2017-7484-induced bugs, or, btree cmp functions are not leakproof?