| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Assertion failure while streaming toasted data |
| Date: | 2021-05-26 06:07:00 |
| Message-ID: | CABOikdPjQp16XY7u__=sJdijK16ndaozsKXBaxewHVaQULw00w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 26, 2021 at 11:19 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
>
>
>
> I searched and didn't find any similar existing tests. Can we think of
> any other way to test this code path? We already have one copy test in
> toast.sql, isn't it possible to write a similar test here?
>
>
Yeah, I wasn't very confident about this either. I just wrote it to reduce
the test footprint in the reproducer. I think we can simply include a lot
more data and do the copy via stdin.
Alternatively, we can reduce logical_decoding_work_mem minimum value and
run the test with a smaller value. But that same GUC is used to decide
spilling txn to disk as well. So I am not sure if reducing the compile time
default is acceptable or not.
Thanks,
Pavan
--
Pavan Deolasee
EnterpriseDB: https://www.enterprisedb..com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-05-26 06:22:36 | Re: Inaccurate error message when set fdw batch_size to 0 |
| Previous Message | Amit Kapila | 2021-05-26 05:49:33 | Re: Assertion failure while streaming toasted data |