| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Index corruption with CREATE INDEX CONCURRENTLY |
| Date: | 2017-02-03 07:39:35 |
| Message-ID: | CABOikdP4jJ0KiA8Q9zJ_39d-nxXZO+JUznBPJ_RJYHRadt7D-g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 2, 2017 at 6:14 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> /*
> + * If the index list was invalidated, we better also invalidate the index
> + * attribute list (which should automatically invalidate other attributes
> + * such as primary key and replica identity)
> + */
>
> + relation->rd_indexattr = NULL;
> +
>
> I think setting directly to NULL will leak the memory.
>
Good catch, thanks. Will fix.
Thanks,
Pavan
--
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tobias Schönit | 2017-02-03 07:52:19 | Harmonization of json functions (SQLITE) |
| Previous Message | Corey Huinker | 2017-02-03 07:16:42 | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |