| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Pavan Deolasee <pavan(dot)deolasee(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: some pointless HeapTupleHeaderIndicatesMovedPartitions calls |
| Date: | 2021-01-18 04:57:11 |
| Message-ID: | CABOikdMKPO08HPu22hieMX+4uAWNEyAveWkheKjLSjDbNdkeKA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Alvaro,
On Tue, Sep 29, 2020 at 10:14 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
> Hello
>
> Pavan Deolasee recently noted that a few of the
> HeapTupleHeaderIndicatesMovedPartitions calls added by commit
> 5db6df0c0117 are useless, since they are done after comparing t_self
> with t_ctid. That's because t_self can never be set to the magical
> values that indicate that the tuple moved partition. If the first
> test fails (so we know t_self equals t_ctid), necessarily the second
> test will also fail.
>
> So these checks can be removed and no harm is done.
>
>
The patch looks good to me. The existing coding pattern was a bit confusing
and that's how I noticed it. So +1 for fixing it.
Thanks,
Pavan
--
Pavan Deolasee
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2021-01-18 05:00:49 | Re: [HACKERS] [PATCH] Generic type subscripting |
| Previous Message | tsunakawa.takay@fujitsu.com | 2021-01-18 04:57:06 | RE: Determine parallel-safety of partition relations for Inserts |