some pointless HeapTupleHeaderIndicatesMovedPartitions calls

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Pavan Deolasee <pavan(dot)deolasee(at)2ndQuadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: some pointless HeapTupleHeaderIndicatesMovedPartitions calls
Date: 2020-09-29 16:44:11
Message-ID: 20200929164411.GA15497@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Pavan Deolasee recently noted that a few of the
HeapTupleHeaderIndicatesMovedPartitions calls added by commit
5db6df0c0117 are useless, since they are done after comparing t_self
with t_ctid. That's because t_self can never be set to the magical
values that indicate that the tuple moved partition. If the first
test fails (so we know t_self equals t_ctid), necessarily the second
test will also fail.

So these checks can be removed and no harm is done.

Álvaro Herrera 39°49'30"S 73°17'W

Attachment Content-Type Size
0001-Remove-pointless-HeapTupleHeaderIndicatesMovedPartit.patch text/x-diff 3.5 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-09-29 16:46:46 Re: Dumping/restoring fails on inherited generated column
Previous Message Pavel Stehule 2020-09-29 16:39:02 Re: calling procedures is slow and consumes extra much memory against calling function