| From: | Joao Detomini <joao(dot)detomini(at)enterprisedb(dot)com> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgbackrest(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_resetwal: refuse to run when backup_label exists |
| Date: | 2026-10-05 15:04:14 |
| Message-ID: | CABH8dKzbf9ukB6SS8U5q0wmzkd4=XZpiTw-6-6+p3Xm922itDA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Shihao,
Nothing to change from my side, v3 looks fine to me. I'll put it
back to Needs review for now, since Michael hasn't said whether he's
ok with -f not overriding the check.
Thanks,
João Marcelo
Em seg., 5 de out. de 2026 às 11:56, shihao zhong <zhong950419(at)gmail(dot)com>
escreveu:
> Hi Joao,
>
> Thanks for testing v3.
>
> > A backup_label looks like that second kind to me, so I'd keep v3
> > as is.
>
> Agreed, I will leave v3 as it is.
>
> I see the CF entry is now Waiting on Author. Is there something you
> want me to change in v3? If not, I think it can go back to Needs
> review, or Ready for Committer if you think it is ready.
>
> Thanks,
> Shihao
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joao Detomini | 2026-10-05 15:13:45 | Limiting WAL retained for archiving, like max_slot_wal_keep_size |
| Previous Message | Trakshan Mishra | 2026-10-05 15:03:22 | Re: Re: Re: Re: [PATCH] Fix segmentation fault caused by reentrancy in RI_Fkey_cascade_del (ri_triggers.c) |