Re: BUG #19633: Unexpected results of IN (subquery) with a non-deterministic collation

пт, 21 авг. 2026 г. в 06:54, Tender Wang <tndrwang(at)gmail(dot)com>:

> The approach looks good to me. I'd suggest adjusting the comment as
> follows:
> ...
> /* so far so good, keep building lists */
> semi_operators = lappend_oid(semi_operators, opno);
>
> /*
> * Ensure that the RHS expression exposes the join operator's input
> * collation. The expression will later be used as a grouping key when
> * unique-ifying the RHS, so its collation must agree with the semijoin
> * equality semantics.
> */
> semi_rhs_exprs =
> lappend(semi_rhs_exprs,
> canonicalize_ec_expression((Expr *) copyObject(right_expr),
> exprType(right_expr),
> op->inputcollid));
>
> Dear Tender,

Thanks for the review.
Made the changes - v2 attached.

--
Regards,
Rachitskiy Andrey