| From: | Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | andrew(at)dunslane(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Residual cleanups for tied objects in PL/Perl |
| Date: | 2026-08-18 05:27:01 |
| Message-ID: | CAB8bMivTgGQrLzvRTf3q7FdyZQk_onxL9sBbmhpGvMGaGFEDBw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Tom!
> Here's a patch to try to clean that up. I think it is wrong that
> the extension modules don't use hek2cstr, so I made them do so.
> (But we probably shouldn't back-patch that: it's a user-visible
> behavioral change and we've not gotten actual field complaints AFAIR.)
>
Agreed
path looks good for me
> > (oh, and for extra credit: why is there a second call of hv_iterinit
> > in plperl_build_tuple_result and plperl_modify_tuple?)
>
> That seems to be just cargo-culted, so I removed those calls.
>
hv_iterinit is good practice to clean up the iterator state, but here it's
redundant and misleading.
--
Regards,
Rachitskiy Andrey
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-08-18 05:37:02 | Re: [BUG] hstore integer overflow when constructing large values |
| Previous Message | Siddharth Kothari | 2026-08-18 05:12:28 | Re: [PATCH] Add RetrieveInstrumentation hook for CustomScan providers |