Re: PostgresNode::_update_pid using undefined variables in tap tests

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PostgresNode::_update_pid using undefined variables in tap tests
Date: 2015-12-09 00:21:15
Message-ID: CAB7nPqTth_K_9=5rv-n1Mv2SRh7pzoKy28fq8_BPCmmNz28K6A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 9, 2015 at 8:57 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Michael Paquier wrote:
>
>> This code should have checked for the return result of open instead of
>> looking at $pidfile. This has been noticed by Noah as well afterwards
>> and already addressed as 9821492.
>
> Oops, sorry I didn't credit you in the commit message.

That's fine. Don't worry.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-12-09 00:27:42 Re: proposal: multiple psql option -c
Previous Message David G. Johnston 2015-12-09 00:03:36 Re: Fwd: Another little thing about psql wrapped expanded output