Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much
Date: 2017-10-13 13:15:04
Message-ID: CAB7nPqTppc5w2nX7jaSu94V+VHfThbvRq12hmLrSiiN6ii1spA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Oct 13, 2017 at 9:46 PM, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
> Shouldn't `jsonb_build_object` and `jsonb_build_array` be strict in this
> patch?

Oh, right. I thought that those were marked as strict already. Their
type cannot be changed in back-branches, but can be on HEAD. While I
agree that build_object should return NULL in this case, what about
build_array? Should it return [NULL] (empty array), or just NULL? I
would think the latter but this can be debated.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2017-10-13 13:48:09 Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much
Previous Message Dmitry Dolgov 2017-10-13 12:46:59 Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexey Chernyshov 2017-10-13 13:37:32 Re: new function for tsquery creartion
Previous Message Dmitry Dolgov 2017-10-13 12:46:59 Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much