Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much
Date: 2017-10-13 12:46:59
Message-ID: CA+q6zcU=6CcmdAdW=J9o-ukmyKYLLL=6-cHYPZNLN5JQr4wRRw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

> On 13 October 2017 at 06:29, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
>
> So I have implemented a patch that fills in intermediate state data when
dong
> a variadic call and feeds that to the JSONB constructor.

Shouldn't `jsonb_build_object` and `jsonb_build_array` be strict in this
patch?
Otherwise one can get a segfault for these cases:

```
=# select jsonb_build_object(variadic NULL::text[]);
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.

=# select jsonb_build_array(variadic NULL::text[]);
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.
```

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2017-10-13 13:15:04 Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much
Previous Message alexey.ermakov 2017-10-13 11:53:20 BUG #14852: Refreshing materialized view might lead to a problem "could not access status of transaction"

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-10-13 13:15:04 Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much
Previous Message Andrew Dunstan 2017-10-13 12:42:05 Re: Still another race condition in recovery TAP tests