Re: Potential data loss of 2PC files

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Potential data loss of 2PC files
Date: 2017-01-03 12:08:43
Message-ID: CAB7nPqTo1hDJSSKUxTFPKubcwB+Uq4Ce_68DoyU+f0mcA=CX-g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 3, 2017 at 8:41 PM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> Are you talking about
> /*
> * Now we can mark ourselves as out of the commit critical section: a
> * checkpoint starting after this will certainly see the gxact as a
> * candidate for fsyncing.
> */
> MyPgXact->delayChkpt = false;
>
> That's while creating the file. I do not see similar code in
> FinishPreparedTransaction() where the 2PC file is removed.

RecordTransactionCommitPrepared() does the same work for COMMIT PREPARED.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2017-01-03 12:11:20 Re: pg_authid.rolpassword format (was Re: Password identifiers, protocol aging and SCRAM protocol)
Previous Message Simon Riggs 2017-01-03 12:06:37 Re: Measuring replay lag