| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Huong Dangminh <huo-dangminh(at)ys(dot)jp(dot)nec(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Hiroshi Yanagisawa <hir-yanagisawa(at)ut(dot)jp(dot)nec(dot)com> |
| Subject: | Re: [PostgreSQL 10] default of hot_standby should be "on"? |
| Date: | 2017-04-27 07:51:19 |
| Message-ID: | CAB7nPqTTi3dQx-TkDXszS-rc2WO8oxwSckc_G3m_WG-T+UF12g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 27, 2017 at 4:33 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Thu, Apr 27, 2017 at 1:58 PM, Huong Dangminh
> <huo-dangminh(at)ys(dot)jp(dot)nec(dot)com> wrote:
>>> On Thu, Apr 27, 2017 at 11:48 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
>>> wrote:
>>> > Thank you for updating the patch. Also maybe we can update line in
>>> > PostgresNode.pm where hot_standby is set to on explicitly.
>>>
>>> I would refrain from doing that, having some parameters listed in the
>>> tests makes the intention behind those perl routines clear.
>
> Hmm, you've got a point. But when we changed the default values
> related to replication we dropped some explicitly settings from the
> regression test code.
Looking at the patch. This is fine:
- # Change a setting and restart
- $node->append_conf('postgresql.conf', 'hot_standby = on');
- $node->restart();
But not that:
print $conf "wal_log_hints = on\n";
- print $conf "hot_standby = on\n";
print $conf "max_connections = 10\n";
This is a minor point though.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2017-04-27 08:00:04 | Re: pg_dump emits ALTER TABLE ONLY partitioned_table |
| Previous Message | Ashutosh Bapat | 2017-04-27 07:41:10 | Re: Partition-wise join for join between (declaratively) partitioned tables |