| From: | Huong Dangminh <huo-dangminh(at)ys(dot)jp(dot)nec(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Hiroshi Yanagisawa <hir-yanagisawa(at)ut(dot)jp(dot)nec(dot)com> |
| Subject: | Re: [PostgreSQL 10] default of hot_standby should be "on"? |
| Date: | 2017-04-27 14:05:33 |
| Message-ID: | 75DB81BEEA95B445AE6D576A0A5C9E936A625ECF@BPXM05GP.gisp.nec.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> >>> I would refrain from doing that, having some parameters listed in the
> >>> tests makes the intention behind those perl routines clear.
> >
> > Hmm, you've got a point. But when we changed the default values
> > related to replication we dropped some explicitly settings from the
> > regression test code.
>
> Looking at the patch. This is fine:
> - # Change a setting and restart
> - $node->append_conf('postgresql.conf', 'hot_standby = on');
> - $node->restart();
>
> But not that:
> print $conf "wal_log_hints = on\n";
> - print $conf "hot_standby = on\n";
> print $conf "max_connections = 10\n";
>
> This is a minor point though.
Thanks, I attached the update patch.
---
Thanks and best regards,
Dang Minh Huong
NEC Solution Innovators, Ltd.
http://www.nec-solutioninnovators.co.jp/en/
| Attachment | Content-Type | Size |
|---|---|---|
| hot_standby.patch | application/octet-stream | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-04-27 14:06:52 | Re: [PATCH] Incremental sort |
| Previous Message | Robert Haas | 2017-04-27 14:03:07 | Re: identity columns |