| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches. |
| Date: | 2015-10-13 01:14:41 |
| Message-ID: | CAB7nPqTMqZADJYmYNdxSoT_S4J2p0pKYFWC_F2YVhOMeTake8g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Oct 13, 2015 at 8:35 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Cause TestLib.pm to define $windows_os in all branches.
>
> Back-port of a part of commit 690ed2b76ab91eb79ea04ee2bfbdc8a2693f2a37 that
> I'd depended on without realizing that it was only added recently. Since
> it seems entirely likely that other such tests will need to be back-patched
> in future, providing the flag seems like a better answer than just putting
> a test in-line.
Is it really worth it back-patching the portions with $windows_os to
back-branches? This indeed makes back-patch a bit easier but the tests
cannot run on Windows because 13d856e1 has not been added in PG <=
9.5.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-10-13 02:31:07 | Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches. |
| Previous Message | Tom Lane | 2015-10-12 23:49:31 | pgsql: Sigh, need "use Config" as well. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-10-13 01:26:14 | Re: bugs and bug tracking |
| Previous Message | Robert Haas | 2015-10-13 01:14:28 | Re: Parallel Aggregate |