| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches. |
| Date: | 2015-10-13 02:31:07 |
| Message-ID: | 4631.1444703467@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, Oct 13, 2015 at 8:35 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Cause TestLib.pm to define $windows_os in all branches.
>>
>> Back-port of a part of commit 690ed2b76ab91eb79ea04ee2bfbdc8a2693f2a37 that
>> I'd depended on without realizing that it was only added recently. Since
>> it seems entirely likely that other such tests will need to be back-patched
>> in future, providing the flag seems like a better answer than just putting
>> a test in-line.
> Is it really worth it back-patching the portions with $windows_os to
> back-branches? This indeed makes back-patch a bit easier but the tests
> cannot run on Windows because 13d856e1 has not been added in PG <=
> 9.5.
Hmm, well, why wasn't that back-patched? We expect these tests to run
on Windows don't we?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-10-13 02:45:06 | Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches. |
| Previous Message | Michael Paquier | 2015-10-13 01:14:41 | Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-10-13 02:40:40 | Re: bugs and bug tracking |
| Previous Message | Noah Misch | 2015-10-13 02:08:31 | Re: Re: [BUGS] BUG #13611: test_postmaster_connection failed (Windows, listen_addresses = '0.0.0.0' or '::') |