| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Chapman Flack <chap(at)anastigmatix(dot)net> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Olson, Ken" <Ken(dot)Olson(at)pega(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: dynloader.h missing in prebuilt package for Windows? |
| Date: | 2016-01-05 22:46:38 |
| Message-ID: | CAB7nPqTAHR006CjkC44BBDmaftHLq2gZLML9ky+Q1VDgt4TZVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 5, 2016 at 11:24 PM, Chapman Flack <chap(at)anastigmatix(dot)net> wrote:
> On 01/05/2016 09:18 AM, Chapman Flack wrote:
>> On 01/05/2016 12:53 AM, Michael Paquier wrote:
>>
>>> That's not a mandatory fix, but I think we had better do it. As long
>>> as dynloader.h is copied in include/, there is no need to keep the
>>> tweak of dfmgr.c to include the definitions those routines.
>>
>> Looking at what you changed, all becomes clear. :)
>
> Out of curiosity, what happens (or what is supposed to happen)
> to port/dynloader/<os-specific>.c ?
For other platforms that go through ./configure, this file is
similarly copied as src/include/dynloader.h. MSVC is a special case..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-01-05 22:47:26 | Re: dynloader.h missing in prebuilt package for Windows? |
| Previous Message | Joshua D. Drake | 2016-01-05 22:32:02 | Re: No Issue Tracker - Say it Ain't So! |